Code Reviews best practices

Day 6: 20 days of learning challenge

Today we will learn about code reviews. I am a maintainer of an Open Source project named Mentorship-iOS and currently I am reviewing a PR (Pull Request) which is related to saving app data locally in order to use the application without active internet connection.

Learning the process of code reviewing and merging is very necessary in order to participate in Google Summer of Codes (GSoC) also. Follow this series of blogs and we will also learn about GSoC.

I will be showing you what are the best practices to follow in order to submit PR in open source project. Most Open Source projects uses CI/CD Continuous Integration and Continuous Delivery thesse are DevOps tactics

First thing to notice is to check wether all the test passes or not of CI/CD. In this case the Travis CI check does not passes.

This build have failed due to calling of a method ‘loadCoredata’ in closure which requires explicit ‘self.’ to make capture semantics explicit

Further explanation and best practices will be shared soon in other blogs.